cmd/dockerd: refactor buildkit init in daemon startup#49040
Merged
vvoland merged 2 commits intomoby:masterfrom Feb 6, 2025
Merged
cmd/dockerd: refactor buildkit init in daemon startup#49040vvoland merged 2 commits intomoby:masterfrom
vvoland merged 2 commits intomoby:masterfrom
Conversation
thaJeztah
force-pushed
the
buildkit_init_timeout_suggestions
branch
from
9b20998 to
d259e10
Compare
thaJeztah
changed the title
- Move the "Daemon has completed initialization" log to where it has actually completed initialization. - Move buildkit init to its own function. - Move the builder options to a separate struct, and change initBuildkit to return it instead of passing the router-options and manipulate it. Co-authored-by: Brian Goff <[email protected]> Co-authored-by: Sebastiaan van Stijn <[email protected]> Signed-off-by: Brian Goff <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
Make it more explicit that callers must call close Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
buildkit_init_timeout_suggestions
branch
from
d259e10 to
2e9e798
Compare
thaJeztah
changed the title
thaJeztah
added
status/2-code-review
area/daemon
vvoland
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd/dockerd: refactor buildkit init in daemon startup
actually completed initialization.
to return it instead of passing the router-options and manipulate it.
cmd/dockerd: initBuildkit: return close-func
Make it more explicit that callers must call close