vendor: github.com/containerd/cgroups v3.0.5#49032
Merged
thaJeztah merged 1 commit intomoby:masterfrom Dec 19, 2024
Merged
Conversation
thaJeztah
commented
Dec 4, 2024
Comment on lines
+245
to
+248
| Domain CgroupType = "domain" | ||
| DomainThreaded CgroupType = "domain threaded" | ||
| DomainInvalid CgroupType = "domain invalid" | ||
| Threaded CgroupType = "threaded" |
Member
Author
There was a problem hiding this comment.
Wondering if this fix is missing other changes; see my comment on the PR;
Member
Author
There was a problem hiding this comment.
- ☝️ PR open for this one cgroup2: Manager.Delete: handle both "threaded" and "domain threaded" containerd/cgroups#358
Member
Author
|
Looks like our code to re-run the case exec.HasPanic():
return fmt.Errorf("rerun aborted because previous run had a suspected panic and some test may not have run")That retry mechanism was added in this PR; |
thaJeztah
force-pushed
the
vendor_cgroups
branch
from
5576255 to
7339269
Compare
vvoland
approved these changes
Dec 19, 2024
Member
Author
|
I was wondering if we should wait for v3.0.5 to be tagged with containerd/cgroups#358 included (not sure if there's other PRs still pending on the repo) @dmcgowan if you could have a peek |
full diff: containerd/cgroups@v3.0.3...v3.0.5 notable changes: - chore: don't log ENOTSUP during parsing PSI files - Add EOPNOTSUPP to err filter for PSI data - cg2: Don't read cgroup.procs when deleting threaded cg - Added cgroup type "domain threaded" and "domain invalid" - switch to github.com/containerd/log - go.mod: update to go1.22 as minimum - deprecate RunningInUserNS() - dont ignore failure to create cgroup after timeout - cgroup2: Manager.Delete: handle both "threaded" and "domain threaded" Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
vendor_cgroups
branch
from
7339269 to
727ab58
Compare
thaJeztah
changed the title
Member
Author
|
thx! Updated to v3.0.5 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor: github.com/containerd/cgroups v3.0.4
full diff: containerd/cgroups@v3.0.3...v3.0.4
notable changes: