Skip to content

[27.x backport] registry: deprecate RepositoryInfo.Class#49013

Merged
thaJeztah merged 1 commit intomoby:27.xfrom
vvoland:49006-27.x
Dec 2, 2024
Merged

[27.x backport] registry: deprecate RepositoryInfo.Class#49013
thaJeztah merged 1 commit intomoby:27.xfrom
vvoland:49006-27.x

Conversation

@vvoland
Copy link
Copy Markdown
Contributor

@vvoland vvoland commented Dec 2, 2024

relates to:

The Class field was added in a12b466 because Docker Hub registry required a special scope to be set for pulling plugins;

HTTP/1.1 401 Unauthorized
...
Www-Authenticate: Bearer realm="https://auth.docker.io/token",service="registry.docker.io",scope="repository(plugin):vieux/sshfs:pull",error="insufficient_scope"

This is no longer a requirement, and the field is no longer set.

This patch deprecates the field and removes its use.

- Description for the changelog

registry: deprecate `RepositoryInfo.Class`. This field is no longer used, and will be removed in the next release.

- A picture of a cute animal (not mandatory but encouraged)

The Class field was added in a12b466 because
Docker Hub registry required a special scope to be set for pulling plugins;

    HTTP/1.1 401 Unauthorized
    ...
    Www-Authenticate: Bearer realm="https://auth.docker.io/token",service="registry.docker.io",scope="repository(plugin):vieux/sshfs:pull",error="insufficient_scope"

This is no longer a requirement, and the field is no longer set.

This patch deprecates the field and removes its use.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 5f91c76)
Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland vvoland added this to the 27.4.0 milestone Dec 2, 2024
@vvoland vvoland self-assigned this Dec 2, 2024
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit a92d4c5 into moby:27.x Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants