Skip to content

Jenkinsfile: modprobe br_netfilter#48993

Merged
austinvazquez merged 1 commit intomoby:masterfrom
thaJeztah:modprobe_br_netfilter
Nov 30, 2024
Merged

Jenkinsfile: modprobe br_netfilter#48993
austinvazquez merged 1 commit intomoby:masterfrom
thaJeztah:modprobe_br_netfilter

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Nov 29, 2024

- What I did

Make sure the module is loaded, as we're not able to load it from within
the dev-container;

time="2024-11-29T20:40:42Z" level=error msg="Running modprobe br_netfilter failed with message: modprobe: WARNING: Module br_netfilter>

Also moving these steps before the "print info" step, so that docker info
doesn't show warnings that bridge-nf-call-iptables and bridge-nf-call-ip6tables
are not loaded.

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member Author

Whoop; this at least fixes the Jenkins situation

@thaJeztah
Copy link
Member Author

I'll make one small change and move the mod probes before "print info" so that the docker info output should hopefully no longer show the warnings;

[2024-11-29T21:20:50.870Z] WARNING: bridge-nf-call-iptables is disabled
[2024-11-29T21:20:50.870Z] WARNING: bridge-nf-call-ip6tables is disabled

@thaJeztah thaJeztah force-pushed the modprobe_br_netfilter branch from 79cd77f to 395e916 Compare November 29, 2024 21:51
@thaJeztah
Copy link
Member Author

Scratch that; moving to before docker info doesn't help; perhaps because it's already running;

[2024-11-29T21:52:25.614Z] WARNING: bridge-nf-call-iptables is disabled
[2024-11-29T21:52:25.614Z] WARNING: bridge-nf-call-ip6tables is disabled

Make sure the module is loaded, as we're not able to load it from within
the dev-container;

    time="2024-11-29T20:40:42Z" level=error msg="Running modprobe br_netfilter failed with message: modprobe: WARNING: Module br_netfilter not found in directory /lib/modules/5.15.0-1072-aws\n" error="exit status 1"

Also moving these steps _before_ the "print info" step, so that docker info
doesn't show warnings that bridge-nf-call-iptables and bridge-nf-call-ip6tables
are not loaded.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the modprobe_br_netfilter branch from 395e916 to cce5dfe Compare November 29, 2024 21:54
@thaJeztah
Copy link
Member Author

OK; restarting the docker service does the trick for that 👍

@austinvazquez
Copy link
Contributor

Pulling this in to unblock others. Thanks for the deep dive.

@austinvazquez austinvazquez merged commit bff7444 into moby:master Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants