Dockerfile: make sure modprobe is available in dev-container#48992
Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
Closed
Dockerfile: make sure modprobe is available in dev-container#48992thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah wants to merge 1 commit intomoby:masterfrom
Conversation
Depending on the host configuration, the `br_netfilter` module may not
be loaded by default. In this situation, docker will try to load the module
through `modprobe`.
Older versions of docker would silently ignore failing to do so, log a message,
and continue;
time="2024-11-29T20:04:58.538404376Z" level=warning msg="Running modprobe bridge br_netfilter failed with message: , error: exec: \"modprobe\": executable file not found in $PATH"
However, starting with db25b0d and
264c15b, we now produce an error, which
in our CI situation caused tests to fail:
=== FAIL: libnetwork/drivers/bridge TestCreateFullOptions (0.04s)
time="2024-11-29T19:03:44Z" level=error msg="Running modprobe br_netfilter failed with message: " error="exec: \"modprobe\": executable file not found in $PATH"
bridge_linux_test.go:280: Failed to create bridge: loadBridgeNetFilterModule failed: cannot restrict inter-container communication: modprobe br_netfilter failed: exec: "modprobe": executable file not found in $PATH
This patch updates the Dockerfile to make sure `modprobe` is available in
the dev-container, which is the environment in which we run out tests.
Following this, we should;
- Check our packaging to make sure `kmod` / `modprobe` is listed as a dependency
- Look for alternatives / fallbacks for situations where `modprobe` is not
available.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
Arf.. that doesn't work; looks like it's just missing as a whole on the updated machines? |
Member
Author
|
I opened a PR for packaging FWIW; |
This was referenced Nov 29, 2024
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending on the host configuration, the
br_netfiltermodule may not be loaded by default. In this situation, docker will try to load the module throughmodprobe.Older versions of docker would silently ignore failing to do so, log a message, and continue;
However, starting with db25b0d and 264c15b, we now produce an error, which in our CI situation caused tests to fail:
This patch updates the Dockerfile to make sure
modprobeis available in the dev-container, which is the environment in which we run out tests.Following this, we should;
kmod/modprobeis listed as a dependencymodprobeis not available.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)