Oh! Interesting, why did jenkins start failing on this? I think some updates were rolled out; wondering if related 🤔

Stacktrace

=== RUN   TestCreateMultipleNetworks
time="2024-11-29T17:26:55Z" level=error msg="Running modprobe br_netfilter failed with message: " error="exec: \"modprobe\": executable file not found in $PATH"
    bridge_linux_test.go:484: Failed to create bridge: loadBridgeNetFilterModule failed: cannot restrict inter-container communication: modprobe br_netfilter failed: exec: "modprobe": executable file not found in $PATH

Oh! Interesting, why did jenkins start failing on this? I think some updates were rolled out; wondering if related 🤔

Hmm, that is odd ... more so because it doesn't look like the test disables ICC or docker-proxy, so it shouldn't want to load the module. We just changed that code but, although it might try to modprobe in more circumstances, it still shouldn't try unless necessary.

Edit: the test does disable ICC (by not explicitly enabling it). So at least that makes sense.

Hm.. it looks consistent for some reason 😢 so not sure what's causing it; https://ci-next.docker.com/public/blue/organizations/jenkins/moby/detail/PR-48988/2/tests

OHMAN went a bit down the rabbit-hole on that one;

• It failed both in master and 27.x [27.x] test-pr #48989
• But passed in 26.1 [26.1] test-pr #48990
• Trying to revert the last changes made no difference [27.x] Revert "Fix br_netfilter module loading logic" #48991
• But reverting to the "pre-27.3" situation did (also [27.x] Revert "Fix br_netfilter module loading logic" #48991)
• But that was a red herring, because it was failing on pre-27.3 (and 26.1) as well, but those versions only logged the error (then went on without complaining)
• So I tried to install modprobe in the dev-container (kmod package); Dockerfile: make sure modprobe is available in dev-container #48992
• But loading the module from inside the dev-container doesn't work
• So, I opened a PR to do a modprobe on the host in the Jenkinsfile, and THAT seems to at least unsettle Jenkins Jenkinsfile: modprobe br_netfilter #48993
• Also opened a PR to add kmod as "recommends" to our packages, so that modprobe is installed if we try to use it [master] deb,rpm: add kmod as recommended dependency to provide modprobe docker/docker-ce-packaging#1118