daemon/config: some refactor and deprecate Config.ValidatePlatformConfig#48985
Merged
thaJeztah merged 4 commits intomoby:masterfrom Nov 28, 2024
Merged
daemon/config: some refactor and deprecate Config.ValidatePlatformConfig#48985thaJeztah merged 4 commits intomoby:masterfrom
thaJeztah merged 4 commits intomoby:masterfrom
Conversation
…nsistency Most validation errors have the "invalid xxxxx" prefix; format this error to be consitent with other errors. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This method was only used internally as part of config.Validate; deprecate it in favor of config.Validate and make it a non-exported function. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
impact/changelog
impact/deprecation
area/go-sdk
impact/go-sdk
1 task
vvoland
approved these changes
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daemon/config: verifyDefaultCgroupNsMode: update error message for consistency
Most validation errors have the "invalid xxxxx" prefix; format this error
to be consitent with other errors.
daemon/config: move utility-functions separate from Config methods
daemon/config: deprecate Config.ValidatePlatformConfig
This method was only used internally as part of config.Validate; deprecate
it in favor of config.Validate and make it a non-exported function.
daemon/config: extract validation of userland-proxy config
- Description for the changelog
- Deprecate daemon/config.Config.ValidatePlatformConfig(). This method was used as helper for config.Validate, which should be used instead.- A picture of a cute animal (not mandatory but encouraged)