daemon: getCD: remove use of parsers.ParseKeyValueOpt#48981
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 28, 2024
Merged
daemon: getCD: remove use of parsers.ParseKeyValueOpt#48981thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
We were discarding the error returned by it, and its functionality is very minimal, so inline the equivalent. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/daemon
Member
Author
|
This test is still flaky; opened a ticket; #48983 |
Member
Author
|
Some Details |
vvoland
approved these changes
Nov 28, 2024
thaJeztah
commented
Nov 28, 2024
| if err != nil || !strings.EqualFold(key, "native.cgroupdriver") { | ||
| continue | ||
| key, val, ok := strings.Cut(option, "=") | ||
| if ok && strings.EqualFold(strings.TrimSpace(key), "native.cgroupdriver") { |
Member
Author
There was a problem hiding this comment.
fwiw; I really want to look at some of these to be more strict altogether (not case-insensitive, and less manipulation of values like trimming spaces etc); I kept the current behavior for now though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were discarding the error returned by it, and its functionality is very minimal, so inline the equivalent.
- A picture of a cute animal (not mandatory but encouraged)