[27.x backport] integration: add wait#48969
Merged
Conversation
Cherry-picked several WIP commits from https://github.com/moby/moby/commits/b0a592798f4d9d7162f8aedca89ada3a29d60e2c/ Originally-authored-by: Rodrigo Campos <[email protected]> Co-Authored-by: Kir Kolyshkin <[email protected]> Signed-off-by: Akihiro Suda <[email protected]> Signed-off-by: Kir Kolyshkin <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit fb6e650) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Nov 27, 2024
Comment on lines
-1092
to
+1102
| resp, err := http.Get("http://[::1]:" + hostPort) | ||
| assert.NilError(t, err) | ||
| var resp *http.Response | ||
| addr := "http://[::1]:" + hostPort | ||
| poll.WaitOn(t, func(t poll.LogT) poll.Result { | ||
| var err error | ||
| resp, err = http.Get(addr) // #nosec G107 -- Ignore "Potential HTTP request made with variable url" | ||
| if err != nil { | ||
| return poll.Continue("waiting for %s to be accessible: %v", addr, err) | ||
| } | ||
| return poll.Success() | ||
| }) |
Member
Author
There was a problem hiding this comment.
This part didn't apply clean because TestProxy4To6 moved to a different file in master, so I just copy/pasta'd the change to the right file in this branch.
Merged
robmry
approved these changes
Nov 27, 2024
Contributor
|
Unrelated test failure ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked several WIP commits from
https://github.com/moby/moby/commits/b0a592798f4d9d7162f8aedca89ada3a29d60e2c/
Originally-authored-by: Rodrigo Campos [email protected]
(cherry picked from commit fb6e650)