[27.x backport] Fix br_netfilter module loading logic#48966
Merged
[27.x backport] Fix br_netfilter module loading logic#48966
Conversation
Checking for `/proc/sys/net/bridge` directory alone is not enough to decide if bridge, br_netfilter module to be loaded. Check for specific file for br_netfilter module and then do modprobe if the file is not found under `/proc/sys/net/bridge` Loading br_netfilter implicitly loads bridge module. fixes: moby#48948 Signed-off-by: Shreenidhi Shedi <[email protected]> (cherry picked from commit 264c15b) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/networking
Member
Author
|
Failure is unrelated and a known flaky; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking for
/proc/sys/net/bridgedirectory alone is not enough to decide if bridge, br_netfilter module to be loaded. Check for specific file for each bridge & br_netfilter module and then do modprobe if the file is not found in/proc/sys/net/bridge- What I did
Fix loading of bridge and br_netfilter kernel modules
- How I did it
By check for presence of specific files for each module in procfs
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)