Closed
Conversation
Signed-off-by: CrazyMax <[email protected]>
thaJeztah
reviewed
Nov 27, 2024
| DOCKER_GRAPHDRIVER: ${{ inputs.storage == 'snapshotter' && 'overlayfs' || 'overlay2' }} | ||
| TEST_INTEGRATION_USE_SNAPSHOTTER: ${{ inputs.storage == 'snapshotter' && '1' || '' }} | ||
| SETUP_BUILDX_VERSION: latest | ||
| SETUP_BUILDX_VERSION: v0.18.0 |
Member
There was a problem hiding this comment.
Not for this PR, but now wondering if we should set a global version, and also override the one we use in the Dockerfile?
Line 15 in f052dbb
Although that would mean that we would not get early warnings on failures in rc's; is there a value other than latest that also includes betas and rc's?
Member
Author
There was a problem hiding this comment.
Yes having some kind of latest-unstable would be good to catch this early
This was referenced Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/moby/moby/actions/runs/12046370143/job/33590391297?pr=48960#step:8:201
Seems to be a bug in latest Buildx 0.19.0 related to bake composable attributes. Let's pin to previous stable to unblock the pipeline