integration: remove default poll delay and timeouts#48956
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 27, 2024
Merged
integration: remove default poll delay and timeouts#48956thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
The default delay is 100ms and default timeout is 10s, so we can remove cases where we are setting the defaults; https://github.com/moby/moby/blob/d8fa0581eeeb1caa5d7f2bef4ac58c0366f92a11/vendor/gotest.tools/v3/poll/poll.go#L115 https://github.com/moby/moby/blob/d8fa0581eeeb1caa5d7f2bef4ac58c0366f92a11/vendor/gotest.tools/v3/poll/poll.go#L39-L40 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
thaJeztah
commented
Nov 26, 2024
| cID := container.Run(ctx, t, apiClient, container.WithCmd("sh", "-c", `mkdir /foo; echo xyzzy > /foo/bar`)) | ||
|
|
||
| poll.WaitOn(t, container.IsInState(ctx, apiClient, cID, "exited"), poll.WithDelay(100*time.Millisecond), poll.WithTimeout(60*time.Second)) | ||
| poll.WaitOn(t, container.IsInState(ctx, apiClient, cID, "exited"), poll.WithTimeout(60*time.Second)) |
Member
Author
There was a problem hiding this comment.
Actually curious why we use exited here, and not container.IsStopped - let me also look what the difference is there. (not for this PR)
Member
Author
|
I'll merge this one after #48940, which is more important and I don't know if it conflicts (and too lazy to check 😂) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default delay is 100ms and default timeout is 10s, so we can remove cases where we are setting the defaults;
moby/vendor/gotest.tools/v3/poll/poll.go
Line 115 in d8fa058
moby/vendor/gotest.tools/v3/poll/poll.go
Lines 39 to 40 in d8fa058
- A picture of a cute animal (not mandatory but encouraged)