Skip to content

Remove buildkit init timeout#48953

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:carry_buildkit_init_timeout
Nov 27, 2024
Merged

Remove buildkit init timeout#48953
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:carry_buildkit_init_timeout

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Nov 26, 2024

Buildkit can take a long time to start, we don't want the daemon to fail to startup because buildkit took too long.

- Description for the changelog



- A picture of a cute animal (not mandatory but encouraged)

    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



                    

          
        





  





    



      

  
        

  

      

  
  

  
          

  

    

      


  

      
        @cpuguy83
  




      

        
          Remove buildkit init timeout
        

          
                        
      


      

        

    
    
    

  

      


      

        

          

    
    
    

  

  

    
  



        

      


      

        
          b7f43c3
        
      

    

  

    

      
Buildkit *can* take a long time to start, we don't want the daemon to fail
to startup because buildkit took too long.

Signed-off-by: Brian Goff <[email protected]>

    







  








      

  
            


    

    

      
    

    


      


          @thaJeztah
thaJeztah




          added this to the 
  28.0.0 milestone


      Nov 26, 2024

    

  



  

  

    
  


  

      


    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Nov 26, 2024
    





  


  

      
   Closed

  







  









      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Nov 26, 2024


      
    


  





      


        



  
    

      
          
Actually wondering if we need this one if the fix in BuildKit is merged and backported;



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Nov 26, 2024


      
    


  





      


        



  
    

      
          
Opened a PR to update buildkit with the "actual" fix for v27.x;



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Nov 26, 2024


      
    


  





      


        



  
    

      
          
Flaky / racy test?


=== Failed
=== FAIL: amd64.integration.container TestCreateWithCDIDevices (1.20s)
    cdi_test.go:67: assertion failed: [] does not contain FOO=injected



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Nov 26, 2024


      
    


  





      


        



  
    

      
          
Failure is unrelated; flaky test that may be fixed through #48940


=== FAIL: amd64.integration.build TestBuildUserNamespaceValidateCapabilitiesAreV2 (10.25s)
Loaded image: busybox:latest
Loaded image: busybox:glibc
Loaded image: debian:bookworm-slim
Loaded image: hello-world:latest
Loaded image: arm32v7/hello-world:latest
Loaded image: hello-world:amd64
Loaded image: hello-world:arm64
    build_userns_linux_test.go:132: run produced invalid output: "", expected "/bin/sleep cap_net_bind_service=eip"



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
            

    

      
    

    


      


          @thaJeztah
thaJeztah




              self-assigned this


      Nov 26, 2024

    

  








      

  
        





      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Nov 26, 2024


      
    


  





      


        



  
    

      
          
And, another unrelated flaky (this one's really flaky recently, also probably related to the runc update);


=== RUN   TestBuildSquashParent
    build_squash_test.go:98: assertion failed: 
        --- ←
        +++ →
        @@ -1 +1,2 @@
        -
        +hello
        +world
        
--- FAIL: TestBuildSquashParent (4.28s)



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
          

  

    
  


  

      


    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Nov 27, 2024
    





  


  

      
   Merged

  







  




    







      

  
        

  

        

  laurazard
  

  
            

              
                    laurazard
  

              

              approved these changes


              
                  
                    Nov 27, 2024
                  
              
              
            


            



                
    View reviewed changes
  


            





          

  
  
  
              

                      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

    

  


  

    

      
          @laurazard
      

      
            laurazard
  

      

      

      left a comment




      
    


  



                  

                      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
LGTM

      
    

  
  




                    

                  
  
  

    
  
    
    

  

  

  



                      

                    
                  








      

  
  
  




  








      

  
          
 
  

    
  

  



        @thaJeztah
  thaJeztah



        merged commit f052dbb
      into

      
  
    moby:master
  


    Nov 27, 2024

  







  

  
  

  
      @thaJeztah
  thaJeztah


    
    deleted the
    
      
        carry_buildkit_init_timeout
    
    branch

    November 27, 2024 09:23    
    




    











  
  

    

      

  










  








  
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  










      

  

    
    

    

  

    Reviewers
  


    


      

  

    


  
      @cpuguy83
  
    cpuguy83


    
      
        
      
    
    cpuguy83 approved these changes



      

  

    


  
      @laurazard
  
    laurazard


    
      
        
      
    
    laurazard approved these changes




      






    
    
    

    

  


      
  

    Assignees
  



        


      

        


  
      @thaJeztah
  
    thaJeztah
    

      








      


  


  

    Labels
  



    

      

    area/builder/buildkit

  Build
  

    area/builder

  Build
  

    kind/bugfix

  PR's that fix bugs
  

    process/cherry-pick/25.0

  

    process/cherry-picked

  

    status/2-code-review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    28.0.0
  





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
        

  

    

      3 participants
    

    

        
          @thaJeztah 
        
          @cpuguy83 
        
          @laurazard