api/types/filters: rewrite / improve some tests#48945
Merged
thaJeztah merged 3 commits intomoby:masterfrom Nov 25, 2024
Merged
Conversation
Member
Author
|
I think this one has become more flaky recently; second time Today that I see it fail; |
vvoland
approved these changes
Nov 25, 2024
| if len(v) != 1 || !v["running"] { | ||
| t.Fatalf("Expected to include a running status, got %v", v) | ||
| } | ||
| assert.Check(t, is.Equal(len(v), 1)) |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| assert.Check(t, is.Equal(len(v), 1)) | |
| assert.Check(t, is.Len(v, 1)) |
Member
Author
There was a problem hiding this comment.
ah, yes, that's cleaner. not sure why I didn't do so; let me fix that.
Use assert.Check() for most cases, instead of failing early. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
8294be6 to
46a91a9
Compare
Member
Author
|
Failure is unrelated, and a test that's currently flaky; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use assert.Check() for most cases, instead of failing early.