client: support multiple platforms on save and load#48902
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 20, 2024
Merged
client: support multiple platforms on save and load#48902thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
containerd-integration
thaJeztah
commented
Nov 19, 2024
| var platform *ocispec.Platform | ||
| if versions.GreaterThanOrEqualTo(httputils.VersionFromContext(ctx), "1.48") { | ||
| if formPlatforms := r.Form["platform"]; len(formPlatforms) > 1 { | ||
| // We don't yet support multiple platforms. |
thaJeztah
force-pushed
the
save_load_multiplat
branch
2 times, most recently
from
f795f84 to
b6cb53e
Compare
Member
Author
|
Looks like we need a timeout on 
|
We don't yet support this at the API level, so for now it returns an error when trying to set multiple, but this makes sure that the client types are already ready for this. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
save_load_multiplat
branch
from
b6cb53e to
9c9eccf
Compare
vvoland
approved these changes
Nov 20, 2024
Member
Author
|
Let me bring this one in, and vendor changes in the CLI repo. As discussed on Slack, I'lll have a look for a follow-up to make similar changes for "History" (mostly for future purposes, so probably will add a comment on that field to describe it as such) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
platformparameter to history, save and load #48295We don't yet support this at the API level, so for now it returns an error when trying to set multiple, but this makes sure that the client types are already ready for this.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)