Skip to content

client: ImageImport: omit empty query-parameters#48897

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:client_import_no_empties
Nov 20, 2024
Merged

client: ImageImport: omit empty query-parameters#48897
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:client_import_no_empties

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Don't set query-parameters for options that weren't set.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added area/cli Client status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Nov 18, 2024
@thaJeztah thaJeztah added this to the 28.0.0 milestone Nov 18, 2024
@thaJeztah thaJeztah self-assigned this Nov 18, 2024
Don't set query-parameters for options that weren't set.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the client_import_no_empties branch from e028ba3 to f303531 Compare November 19, 2024 12:31
@thaJeztah thaJeztah marked this pull request as ready for review November 19, 2024 12:31
Copy link
Copy Markdown
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit e5c2b5e into moby:master Nov 20, 2024
@thaJeztah thaJeztah deleted the client_import_no_empties branch November 20, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli Client kind/refactor PR's that refactor, or clean-up code status/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants