daemon/logger: un-export RingLogger#48893
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 15, 2025
Merged
Conversation
thaJeztah
added
area/logging
status/2-code-review
area/daemon
It doesn't look like this type was intended for external use; constructing a RingLogger can be done through the `NewRingLogger()` constructor, which returns a `Logger` interface (implemented by `RingLogger`). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
logger_cleans
branch
from
04b01ba to
1b9c09e
Compare
thaJeztah
commented
Jan 15, 2025
Comment on lines
25
to
26
| var ( | ||
| _ SizedLogger = (*RingLogger)(nil) | ||
| _ SizedLogger = (*ringLogger)(nil) | ||
| _ LogReader = (*ringWithReader)(nil) |
Member
Author
There was a problem hiding this comment.
Actually wondering if (but for a follow-up) NewRingLogger should explicitly return a SizedLogger, because that's what's implemented by both;
Lines 53 to 55 in 264801e
And perhaps assert that here as well for ringWithReader;
_ SizedLogger = (*ringWithReader)(nil)
vvoland
approved these changes
Jan 15, 2025
Member
Author
|
Let me bring this one in; I'll have a look at those other changes in a follow up if I find some time 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't look like this type was intended for external use; constructing a RingLogger can be done through the
NewRingLogger()constructor, which returns aLoggerinterface (implemented byRingLogger).- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)