fix missing go:build tags#48884
Merged
thaJeztah merged 3 commits intomoby:masterfrom Nov 15, 2024
Merged
Conversation
This was introduced in ba454f5; make BIND_DIR=. shell make -C ./internal/gocompat/ GO111MODULE=on go test -v # github.com/docker/docker/daemon/containerd ../../daemon/containerd/image_inspect.go:107:18: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) FAIL gocompat [build failed] Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was introduced in 3f2e9da; make BIND_DIR=. shell make -C ./internal/gocompat/ GO111MODULE=on go test -v # github.com/docker/docker/api/server/router/container ../../api/server/router/container/inspect.go:29:18: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) FAIL gocompat [build failed] Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was introduced in 1832774; make BIND_DIR=. shell make -C ./internal/gocompat/ GO111MODULE=on go test -v # github.com/docker/docker/libnetwork ../../libnetwork/sandbox.go:588:6: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod) FAIL gocompat [build failed] Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/bugfix
Member
Author
|
Removed the cherry-pick label, because #48885 contains a reduced version of this for the 27.x branch |
vvoland
approved these changes
Nov 15, 2024
Benehiko
approved these changes
Nov 15, 2024
laurazard
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
daemon/containerd: add missing go:build tag
This was introduced in ba454f5;
api/server/router/container: add missing go:build tag
This was introduced in 3f2e9da;
libnetwork: add missing go:build tag
This was introduced in 1832774;