hack: Add explicit containerd feature to daemon.json#48860
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 13, 2024
Merged
hack: Add explicit containerd feature to daemon.json#48860thaJeztah merged 1 commit intomoby:masterfrom
daemon.json#48860thaJeztah merged 1 commit intomoby:masterfrom
Conversation
While it's still turned off by default, it's easier to just flip the `false` to `true` inside the devcontainer. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
added
area/testing
containerd-integration
Member
|
Perhaps we should also remove this "feature"; which currently requires me to explicitly override the storage-driver in various cases; Line 5 in a95a678 |
tianon
approved these changes
Nov 13, 2024
thaJeztah
reviewed
Nov 18, 2024
Comment on lines
+7
to
9
| "features": { | ||
| "containerd-snapshotter": false | ||
| } |
Member
There was a problem hiding this comment.
DOH! Erm.. wondering if this makes things, erm, easier, or not. I was used to using the --feature option to enable/disable in my dev-shell, but forgot that this will now cause an error;
dockerd --feature containerd-snapshotter --debug
unable to configure the Docker daemon with file /etc/docker/daemon.json: the following directives are specified both as a flag and in the configuration file: features: (from flag: map[containerd-snapshotter:true], from file: map[containerd-snapshotter:false])
Contributor
Author
There was a problem hiding this comment.
Oh, right 🙈
To be honest, I got bit by this behavior multiple times with the --debug flag. Do you remember what was the reason we barf out instead of just making the CLI option take the precedence?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small quality of life enhancement if you run the dev container a lot for testing the containerd integration.
While it's still turned off by default, it's easier to just flip the
falsetotrueinside the devcontainer.