hack/make.sh: disable compiling "gogo-protobuf" in typeurl#48833
Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
Closed
hack/make.sh: disable compiling "gogo-protobuf" in typeurl#48833thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah wants to merge 1 commit intomoby:masterfrom
Conversation
commit 0af6203 updated typeurl to v2.2.3, which now provides a `no_gogo` build-tag to allow compiling without gogo- protobuf support. BuildKit v0.17 and above no longer require gogo-protobuf, so we can use this build-tag to disable it. Note that SwarmKit still uses gogo-protobuf, but doesn't use typeurl, so this change wont affect that code. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/packaging
kind/refactor
thaJeztah
commented
Nov 7, 2024
| github.com/containerd/log v0.1.0 | ||
| github.com/containerd/platforms v0.2.1 | ||
| github.com/containerd/typeurl/v2 v2.2.3 | ||
| github.com/containerd/typeurl/v2 v2.2.3 // TODO(thaJeztah): remove "no_gogo" build-tag from hack/make.sh once we update to v2.3.0 |
Member
Author
There was a problem hiding this comment.
Next (v2.3.0) version removes it entirely; see
Member
|
Glad that CI passes, however I'm not sure this is really needed since we already have a hard dependency on gogo due to swarmkit. |
Member
Author
|
Yeah, that's a good point; I actually thought that it would save some space when not compiling it for this package, but .. savings are .. erm... minimal; diff -u before.txt after.txt
--- before.txt 2024-11-07 20:44:17.920670958 +0000
+++ after.txt 2024-11-07 20:44:48.465303010 +0000
@@ -6,7 +6,7 @@
-rwxr-xr-x 1 root root 19595416 Nov 7 20:44 ctr
-rwxr-xr-x 1 root root 601288 Nov 7 20:44 docker-init
-rwxr-xr-x 1 root root 2408597 Nov 7 20:44 docker-proxy
--rwxr-xr-x 1 root root 71620664 Nov 7 20:44 dockerd
+-rwxr-xr-x 1 root root 71618616 Nov 7 20:44 dockerd
-rwxr-xr-x 1 root root 15149 Nov 7 20:44 dockerd-rootless-setuptool.sh
-rwxr-xr-x 1 root root 7249 Nov 7 20:44 dockerd-rootless.sh
-rwxr-xr-x 1 root root 12625520 Nov 7 20:44 rootlesskitMinimal as in; 71620664 - 71618616 = 2048 😂 I guess that's .. very minimal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 0af6203 updated typeurl to v2.2.3, which now provides a
no_gogobuild-tag to allow compiling without gogo- protobuf support. BuildKit v0.17 and above no longer require gogo-protobuf, so we can use this build-tag to disable it.Note that SwarmKit still uses gogo-protobuf, but doesn't use typeurl, so this change wont affect that code.
- A picture of a cute animal (not mandatory but encouraged)