vendor: github.com/containerd/typeurl v2.2.3#48827
Conversation
|
@cpuguy83 looking at your PR; I think for containerd 1.7 we still need it, correct?
|
|
thaJeztah
force-pushed
the
bump_typeurl
branch
from
190e7d6 to
ab7c9ff
Compare
thaJeztah
changed the title
- add a `no_gogo` build-tag to allow compiling without support for gogoproto (github.com/gogo/protobuf) - fix panic when type is not found and no handler is hit. - fix unmarshalling of registered types full diff: containerd/typeurl@v2.2.0...v2.2.3 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
bump_typeurl
branch
from
ab7c9ff to
0af6203
Compare
| @@ -0,0 +1,68 @@ | |||
| //go:build !no_gogo | |||
There was a problem hiding this comment.
looking at your PR; I think for containerd 1.7 we still need it, correct?
FWIW; Yesterday I accidentally first pushed this PR and forgot to stage the new _gogo.go files. CI was happy with those missing, so it looks indeed that (now that BuildKit no longer uses gogo) we don't need the gogo support.
I can open a follow-up PR to add the no_gogo build-tag (also in our packaging repositories); I didn't want to stash that in this PR together with the other changes.
There was a problem hiding this comment.
2 participants
no_gogobuild-tag to allow compiling without support for gogoproto (github.com/gogo/protobuf)full diff: containerd/typeurl@v2.2.0...v2.2.3
- A picture of a cute animal (not mandatory but encouraged)