fix, and update golangci-lint config, and fix some linting issues#48824
Merged
thaJeztah merged 9 commits intomoby:masterfrom Nov 6, 2024
Merged
fix, and update golangci-lint config, and fix some linting issues#48824thaJeztah merged 9 commits intomoby:masterfrom
thaJeztah merged 9 commits intomoby:masterfrom
Conversation
Use a consistent order, which helps comparing settings with other repositories, such as docker/cli. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
We only have a few locations where it's flagged, so we can add ignores there. Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's now a top-level option, with exclude-dirs in the "issues" section Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
The govet linter now uses a new schema for its config; let's remove for now, and work on enabling more of its functionality in a follow-up. Signed-off-by: Sebastiaan van Stijn <[email protected]>
austinvazquez
approved these changes
Nov 6, 2024
vvoland
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see individual commits for details; some follow-ups will come after this one
- A picture of a cute animal (not mandatory but encouraged)