client: Client.ImageHistory: don't decorate error twice, and improve tests#48819
Merged
thaJeztah merged 3 commits intomoby:masterfrom Nov 5, 2024
Merged
client: Client.ImageHistory: don't decorate error twice, and improve tests#48819thaJeztah merged 3 commits intomoby:masterfrom
thaJeztah merged 3 commits intomoby:masterfrom
Conversation
I forgot to include this patch in 9603927, which introduced the encodePlatform, which already decorates the error to have a `invalid platform:` prefix. While updating, also be more explicit on no result being returned on error. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Use a fixture instead of encoding with the current definition of the type, to make sure we don't regress if any changes are made in the type. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
vvoland
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client: Client.ImageHistory: don't decorate error twice
I forgot to include this patch in 9603927,
which introduced the encodePlatform, which already decorates the error to
have a
invalid platform:prefix.While updating, also be more explicit on no result being returned on error.
client: TestImageHistory: use fixture for JSON response
Use a fixture instead of encoding with the current definition of the type,
to make sure we don't regress if any changes are made in the type.
client: TestImageHistory: add minimal test for platform
- A picture of a cute animal (not mandatory but encouraged)