Skip to content

chore: fix function name#48813

Merged
thaJeztah merged 1 commit intomoby:masterfrom
tcpdumppy:patch-1
Nov 5, 2024
Merged

chore: fix function name#48813
thaJeztah merged 1 commit intomoby:masterfrom
tcpdumppy:patch-1

Conversation

@tcpdumppy
Copy link
Copy Markdown
Contributor

- What I did

fix comment (function name)

- How I did it

- How to verify it

- Description for the changelog

fix function name

- A picture of a cute animal (not mandatory but encouraged)

image

@thaJeztah
Copy link
Copy Markdown
Member

Thank you for contributing! It appears your commit message is missing a DCO sign-off,
causing the DCO check to fail.

We require all commit messages to have a Signed-off-by line with your name
and e-mail (see "Sign your work"
in the CONTRIBUTING.md in this repository), which looks something like:

Signed-off-by: YourFirsName YourLastName <[email protected]>

There is no need to open a new pull request, but to fix this (and make CI pass),
you need to amend the commit(s) in this pull request, and "force push" the amended
commit.

Unfortunately, it's not possible to do so through GitHub's web UI, so this needs
to be done through the git commandline.

You can find some instructions in the output of the DCO check (which can be found
in the "checks" tab on this pull request), as well as in the Moby contributing guide.

Steps to do so "roughly" come down to:

  1. Set your name and e-mail in git's configuration:

    git config --global user.name "YourFirstName YourLastName"
    git config --global user.email "[email protected]"

    (Make sure to use your real name (not your GitHub username/handle) and e-mail)

  2. Clone your fork locally

  3. Check out the branch associated with this pull request

  4. Sign-off and amend the existing commit(s)

    git commit --amend --no-edit --signoff

    If your pull request contains multiple commits, either squash the commits (if
    needed) or sign-off each individual commit.

  5. Force push your branch to GitHub (using the --force or --force-with-lease flags) to update the pull request.

Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions!

@thaJeztah thaJeztah added status/2-code-review dco/no Automatically set by a bot when one of the commits lacks proper signature labels Nov 4, 2024
Signed-off-by: tcpdumppy <[email protected]>
@tcpdumppy
Copy link
Copy Markdown
Contributor Author

Thank you for contributing! It appears your commit message is missing a DCO sign-off, causing the DCO check to fail.

We require all commit messages to have a Signed-off-by line with your name and e-mail (see "Sign your work" in the CONTRIBUTING.md in this repository), which looks something like:

Thanks for your patient guidance.

Modified, thank you very much!

@thaJeztah thaJeztah added status/4-merge and removed status/2-code-review dco/no Automatically set by a bot when one of the commits lacks proper signature labels Nov 5, 2024
@thaJeztah thaJeztah added this to the 28.0.0 milestone Nov 5, 2024
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

LGTM

@thaJeztah thaJeztah merged commit f0cec02 into moby:master Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants