Remove libnetwork_test.TestMain#48796
Merged
robmry merged 1 commit intomoby:masterfrom Oct 30, 2024
Merged
Conversation
It only removed the test host's libnet Bolt db file, and didn't need to do that because the tests use a TempDir for it. Signed-off-by: Rob Murray <[email protected]>
robmry
added
area/networking
akerouanton
approved these changes
Oct 30, 2024
Member
|
I think we may be able to get rid of the But I'll have a look at that; I think we have some stubs that are just to make it "not barf" on macOS, and there's some bits that pretend they're supporting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
Remove
libnetwork_test.TestMain.It only removed the test host's libnet Bolt db file, and didn't need to do that because the tests use a TempDir for it.
- How to verify it
With the
TestMainin place, the tests didn't create/var/lib/docker/network/files/local-kv.db. And, with it gone, the file is not modified by the tests.- Description for the changelog