builder-next: exporter: emptyImageConfig: use platform directly#48794
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 30, 2024
Merged
builder-next: exporter: emptyImageConfig: use platform directly#48794thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
The OCI image spec now has the platform as field, so we can just set it directly now. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
vvoland
approved these changes
Oct 30, 2024
thaJeztah
commented
Oct 30, 2024
| Platform: pl, | ||
| Config: ocispec.ImageConfig{ | ||
| WorkingDir: "/", | ||
| Env: []string{"PATH=" + system.DefaultPathEnv(pl.OS)}, |
Member
Author
There was a problem hiding this comment.
FWIW, DefaultSpec() always sets OS to runtime.GOOS, so I was considering for a second to set that here, but perhaps using the pl.OS is more "correct" here in case DefaultSpec() would ever do some "magic".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OCI image spec now has the platform as field, so we can just set it directly now.
- A picture of a cute animal (not mandatory but encouraged)