container create: add warning for volumeDriver together with mounts#48789
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 30, 2024
Merged
container create: add warning for volumeDriver together with mounts#48789thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
area/api
vvoland
approved these changes
Oct 29, 2024
Contributor
|
LGTM; although the changelog description could use some love 😅 |
Member
Author
|
Updated the changelog entry a bit. Actually, I should probably include it in the API changelog; let me update. |
thaJeztah
force-pushed
the
volumedriver_warning
branch
from
aefa0c2 to
c633817
Compare
Member
Author
|
Updated |
commit 77fe35b added a warning if the "volumeDriver" option was used in combination with --mount. That change put the warning in the CLI, which should not have to handle this logic. Let's move it to the daemon as we have a warnings response in the container create response. The warning is gated by API version, so that older clients can continue to produce the warning client-side. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
volumedriver_warning
branch
from
c633817 to
cb96607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--mounttodocker run#32251commit 77fe35b added a warning if the "volumeDriver" option was used in combination with --mount.
That change put the warning in the CLI, which should not have to handle this logic. Let's move it to the daemon as we have a warnings response in the container create response.
The warning is gated by API version, so that older clients can continue to produce the warning client-side.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)