Skip to content

Fix: #48747#48780

Closed
guptashivam-9370 wants to merge 1 commit intomoby:masterfrom
guptashivam-9370:master
Closed

Fix: #48747#48780
guptashivam-9370 wants to merge 1 commit intomoby:masterfrom
guptashivam-9370:master

Conversation

@guptashivam-9370
Copy link

fixes #48747

Pull Request Description

- What I did

Fixed the issue where docker image inspect contains duplicate RepoDigests when using containerd image store.

- How I did it

Added a helper function to remove duplicates from RepoDigests list in ImageInspect function.

- How to verify it

  1. Build and tag image with multiple tags.
  2. Push image to a registry.
  3. Inspect image using docker image inspect.
  4. Verify that RepoDigests list does not contain duplicates.

- Description for the changelog

Fixed duplicate `RepoDigests` in `docker image inspect` when using the containerd image store.

- A picture of a cute animal (not mandatory but encouraged)
images

@thaJeztah
Copy link
Member

Thank you for contributing; it looks like there was a bit of a race condition, and a pull request was already opened to fix this;

I'll close this PR, because this one is missing a DCO sign-off and the other PR also adds tests, but thank you so much for contributing!

@thaJeztah thaJeztah closed this Oct 28, 2024
@thaJeztah thaJeztah added dco/no Automatically set by a bot when one of the commits lacks proper signature kind/duplicate labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco/no Automatically set by a bot when one of the commits lacks proper signature kind/duplicate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

c8d: image inspect should not contain duplicate RepoDigests

2 participants