c8d/inspect: Fix duplicate RepoDigests#48777
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 28, 2024
Merged
Conversation
vvoland
added
status/2-code-review
kind/bugfix
vvoland
force-pushed
the
c8d-inspect-duplicate-repodigests
branch
from
0a85671 to
a4a1e19
Compare
thaJeztah
reviewed
Oct 28, 2024
Member
|
@vvoland looks like someone else also just opened a PR for this 😂 |
vvoland
force-pushed
the
c8d-inspect-duplicate-repodigests
branch
from
a4a1e19 to
8e2a376
Compare
akerouanton
reviewed
Oct 28, 2024
vvoland
force-pushed
the
c8d-inspect-duplicate-repodigests
branch
from
8e2a376 to
0d47a82
Compare
Multiple images with the same repository name but different tag caused the `RepoDigests` to contain duplicated entries for each of the image. Deduplicate the slice before setting the `RepoDigests` field. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
c8d-inspect-duplicate-repodigests
branch
2 times, most recently
from
1c00cb9 to
ba454f5
Compare
Closed
akerouanton
approved these changes
Oct 28, 2024
laurazard
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple images with the same repository name but different tag caused the
RepoDigeststo contain duplicated entries for each of the image.Use a set instead of a slice to store the digested references to avoid the duplicated values.
- How to verify it
TestImageInspectUniqueRepoDigests
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)