internal/safepath: log some unhandled errors, and remove workaround for ECI / Sysbox#48774
Merged
thaJeztah merged 3 commits intomoby:masterfrom Oct 28, 2024
Merged
internal/safepath: log some unhandled errors, and remove workaround for ECI / Sysbox#48774thaJeztah merged 3 commits intomoby:masterfrom
thaJeztah merged 3 commits intomoby:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Similar to the kubernetesSafeOpen function. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This workaround was added in 9a0cde6 to work around an issue on Docker Desktop with ECI (Enhanced Container Isolation) enabled, which uses the Sysbox runtime under the hood. A comment was added during review of the PR that added it (see [1]), and the internal discussion on Slack tracked down the issue to code in [nestybox/sysfs]. That issue was resolved Sysbox EE, and upstreamed to Sysbox CE through [nestybox/sysbox-fs@9cf74e4], which is part of Sysbox CE v0.6.3, so we can remove this workaround. [1]: moby#45687 (comment) [nestybox/sysfs]: https://github.com/nestybox/sysbox-fs/blob/30fd49edbd51048fed8b2ad0af327598d30b29eb/process/process.go#L644-L684 [nestybox/sysbox-fs@9cf74e4]: nestybox/sysbox-fs@9cf74e4 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/volumes
vvoland
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/safepath: kubernetesSafeOpen: explicitly suppress unhandled err
internal/safepath: Join(): log some unhandled errors
Similar to the kubernetesSafeOpen function.
internal/safepath: Join(): remove workaround for ECI / Sysbox
This workaround was added in 9a0cde6 to
work around an issue on Docker Desktop with ECI (Enhanced Container Isolation)
enabled, which uses the Sysbox runtime under the hood.
A comment was added during review of the PR that added it (see 1), and the
internal discussion on Slack tracked down the issue to code in nestybox/sysfs.
That issue was resolved Sysbox EE, and upstreamed to Sysbox CE through
nestybox/sysbox-fs@9cf74e4, which is part of Sysbox CE v0.6.3, so we
can remove this workaround.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)