[27.x] c8d/httpfallback: Handle connection errors#48758
Merged
Conversation
vvoland
added
status/2-code-review
kind/bugfix
thaJeztah
reviewed
Oct 25, 2024
Adjust the httpFallback implementation to also handle non-TLS related errors which can also happen when issuing a HTTPS requested to HTTP-only registries. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
c8d-httpfallback-adjust
branch
from
ddf384b to
de01359
Compare
laurazard
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This only targets the 27.x branch, as #47380 (for master branch) will remove our httpFallback and use the one from containerd.
This is a minimal patch that aligns the httpFallback implementation to support the same fallback conditions as the containerd one.
- What I did
Adjust the httpFallback implementation to also handle non-TLS related errors which can also happen when issuing a HTTPS requested to HTTP-only registries.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)