ci: re-add firewalld jobs#48756
Merged
thaJeztah merged 1 commit intomoby:masterfrom Nov 12, 2024
Merged
Conversation
akerouanton
force-pushed
the
reduce-number-of-firewalld-jobs
branch
17 times, most recently
from
1b4d2a3 to
ecaa2b8
Compare
akerouanton
force-pushed
the
reduce-number-of-firewalld-jobs
branch
7 times, most recently
from
319ba70 to
eecc290
Compare
Commit 4e567e1 added firewalld to the test matrix for various CI jobs (namely unit, integration and integration-cli). Commit 2807c0c reverted that commit as it was putting too much load on GHA cache, and thus it was returning 429 more frequently, so builds had a greater chance of spending time building everything from scratch. This was slowing down our CI even more than what it was before. This new commit re-adds firewalld to the test matrix of unit, integration and integration-cli jobs. Unlike 4e567e1, not all combinations of OS, storage and 'mode' will be tested. Instead, firewalld jobs will run only on ubuntu-22.04, and with the containerd snapshotter. Also, the revert commit mistakenly reverted a fix that was originally intended for commit 8883db2, but was actually 'fixed up' in the wrong commit. Let's re-revert that too. Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
force-pushed
the
reduce-number-of-firewalld-jobs
branch
from
eecc290 to
816dbbf
Compare
akerouanton
commented
Oct 31, 2024
| // Moreover, since the goal is to run only relevant tests with | ||
| // firewalld enabled to minimize the number of CI jobs, we | ||
| // statically define the list of test suites that we want to run. | ||
| if ("${{ inputs.storage }}" == "snapshotter") { |
Member
Author
There was a problem hiding this comment.
integration-cli test suites are deprecated, and the test/validate GHA job executes hack/validate/deprecate-integration-cli which should error out if any new test is added to the integration-cli test suites. So I assume it's perfectly fine to define these suites statically.
thaJeztah
added
status/2-code-review
area/testing
area/networking/firewalld
akerouanton
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Follow-up for:
Commit 4e567e1 added firewalld to the test matrix for various CI jobs (namely unit, integration and integration-cli).
Commit 2807c0c reverted that commit as it was putting too much load on GHA cache, and thus it was returning 429 more frequently, so builds had a greater chance of spending time building everything from scratch. This was slowing down our CI even more than what it was before.
This new commit re-adds firewalld to the test matrix of unit, integration and integration-cli jobs. Unlike 4e567e1, not all combinations of OS, storage and 'mode' will be tested. Instead, firewalld jobs will run only on ubuntu-22.04, and with the containerd snapshotter.
Also, the revert commit mistakenly reverted a fix that was originally intended for commit 8883db2, but was actually 'fixed up' in the wrong commit. Let's re-revert that too.
- How I did it
- How to verify it