inte/t/networking: delete veth ifaces before netns#48749
Merged
akerouanton merged 1 commit intomoby:masterfrom Oct 25, 2024
Merged
inte/t/networking: delete veth ifaces before netns#48749akerouanton merged 1 commit intomoby:masterfrom
akerouanton merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
added
area/networking
robmry
approved these changes
Oct 24, 2024
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
When a netns is deleted while there's still veth interfaces in it, the kernel delete both ends of the veth pairs. The veth interface living in that netns will be deleted instantaneously, but the other end will be reclaimed after a short delay.
If, in the meantime, a new test is spun up, and tries to create a new veth pair with the same peer name, the kernel will return -EEXIST.
But, if the veth pair is explicitly deleted before the netns, then both veth ends will be deleted instantaneously.
Hence, we need to do just that here.
- How to verify it
This was manually tested on #48721 with:
TESTFLAGS='-test.run (TestAccessPublishedPortFromNonMatchingIface|TestAccessPublishedPortFromRemoteHost)'.