Skip to content

vendor: github.com/cyphar/filepath-securejoin v0.3.4#48732

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_securejoin
Oct 23, 2024
Merged

vendor: github.com/cyphar/filepath-securejoin v0.3.4#48732
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:bump_securejoin

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Oct 23, 2024

full diff: cyphar/filepath-securejoin@v0.2.4...v0.3.4

- Description for the changelog



- A picture of a cute animal (not mandatory but encouraged)

    

  
  



      


          

          
  
  

    
  
    
    

  

  

  



                    

          
        





  





    



      

  
        





      

  
            


    

    

      
    

    


      


          @thaJeztah
thaJeztah




          added this to the 
  28.0.0 milestone


      Oct 23, 2024

    

  



    

    

      
    

    


      


          @thaJeztah
thaJeztah




              self-assigned this


      Oct 23, 2024

    

  



  

  

    
  


  

      


    @thaJeztah
thaJeztah



    mentioned this pull request
    
      Oct 23, 2024
    





  


  

      
   Merged

  





  
  

      
        
      
      


  
    
    
  


    4 tasks
  





  









      

  
      



  

  @thaJeztah






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
  Member


        

  Author


    

  


  

    

      
          
      

      
            thaJeztah
  

      

      

      commented


        Oct 23, 2024


      
    


  





      


        



  
    

      
          
Some flakiness on Windows;


=== Failed
=== FAIL: github.com/docker/docker/integration/networking TestNatNetworkICC/User_defined_nat_network (8.90s)
    nat_windows_test.go:62: assertion failed: error is not nil: Post "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.48/containers/3554267c77ca4f74ed6dfaf1f4d8b5553ba53a421232e64e6040aaf334d36f64/start": context deadline exceeded
    panic.go:626: assertion failed: error is not nil: Error response from daemon: error while removing network: network mynat id 08b42ba601821e5b79752518f2320b75272ee9bb1af9aa19565ef5ceba1ba63f has active endpoints

=== FAIL: github.com/docker/docker/integration/networking TestNatNetworkICC (16.85s)

=== FAIL: github.com/docker/docker/integration/networking TestPortMappedHairpinWindows (12.61s)
    nat_windows_test.go:108: assertion failed: error is not nil: Post "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.48/containers/3480bea22b399aafa13594967be26ab3782f77df5b9bf5c0523d4f42b48bbb53/start": context deadline exceeded
    panic.go:626: assertion failed: error is not nil: Error response from daemon: error while removing network: network clientnet id b4f5574716026486e8bc50c0d7bf78f05dbb93b2d16d64474ae08e60cf627a71 has active endpoints



      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        





      

  
          
 
  

    
  

  



        @thaJeztah
  thaJeztah



        merged commit 43bbacb
      into

      
  
    moby:master
  


    Oct 23, 2024

  







  

  
  

  
      @thaJeztah
  thaJeztah


    
    deleted the
    
      
        bump_securejoin
    
    branch

    October 23, 2024 13:24    
    













  
  

    

      

  










  








  
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  










      

  

    
    

    

  

    Reviewers
  


    


      

  

    


  
      @robmry
  
    robmry


    
      
        
      
    
    robmry approved these changes




      






    
    
    

    

  


      
  

    Assignees
  



        


      

        


  
      @thaJeztah
  
    thaJeztah
    

      








      


  


  

    Labels
  



    

      

    area/dependencies

  

    area/runtime

  Runtime
  

    status/2-code-review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    28.0.0
  





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
        

  

    

      2 participants
    

    

        
          @thaJeztah 
        
          @robmry