daemon: Daemon.newContainer: inline Daemon.generateHostname#48704
Merged
thaJeztah merged 2 commits intomoby:masterfrom Oct 21, 2024
Merged
daemon: Daemon.newContainer: inline Daemon.generateHostname#48704thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
area/daemon
austinvazquez
approved these changes
Oct 20, 2024
AkihiroSuda
reviewed
Oct 21, 2024
AkihiroSuda
approved these changes
Oct 21, 2024
generateHostname was only used here, and defined as a method on Daemon without depending on the daemon type. Inline the function and simplify the logic (as both the "network=host" and non-host code only had to be executed if no hostname was set). Signed-off-by: Sebastiaan van Stijn <[email protected]>
The error would always be nil at this point, so let's make that explicit. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
refactor_hostname
branch
from
d7b0023 to
d9ae342
Compare
AkihiroSuda
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateHostname was only used here, and defined as a method on Daemon without depending on the daemon type. Inline the function and simplify the logic (as both the "network=host" and non-host code only had to be executed if no hostname was set).