Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 0d36ab1) Signed-off-by: Austin Vazquez <[email protected]>
The withTxn function takes a custom function to execute; we should not wrap those errors as the only responsibility of this function is to execute the given function in a transaction. This was introduced in 6549a27, and an oversight of me. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 0603bd9) Signed-off-by: Austin Vazquez <[email protected]>
Follow-up to 94dea20. Change these to return errdefs types, which could allow us to move away from the sentinel errors defined in the package, and instead use errdefs definitions. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 0200c58) Signed-off-by: Austin Vazquez <[email protected]>
Use errdefs definitions instead. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 3cf90ca) Signed-off-by: Austin Vazquez <[email protected]>
thaJeztah
added
status/2-code-review
impact/deprecation
kind/refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)