Skip to content

dockerd-rootless-setuptool.sh: let --force ignore smoke test errors#48683

Merged
thaJeztah merged 1 commit intomoby:masterfrom
AkihiroSuda:fix-48678
Oct 18, 2024
Merged

dockerd-rootless-setuptool.sh: let --force ignore smoke test errors#48683
thaJeztah merged 1 commit intomoby:masterfrom
AkihiroSuda:fix-48678

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Oct 17, 2024

- What I did

Now dockerd-rootless-setuptool.sh install --force ignores errors from rootlesskit.

This might be useful when installing Rootless Docker into a container image with RUN instructions.

- How I did it
Check --force

- How to verify it
dockerd-rootless-setuptool.sh install --force

- Description for the changelog

dockerd-rootless-setuptool.sh: let --force ignore smoke test errors

- A picture of a cute animal (not mandatory but encouraged)
🐧

Now `dockerd-rootless-setuptool.sh install --force` ignores errors
from `rootlesskit`.

This might be useful when installing Rootless Docker into a container
image with `RUN` instructions.

Fix issue 48678

Signed-off-by: Akihiro Suda <[email protected]>
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit ba222fc into moby:master Oct 18, 2024
@thaJeztah thaJeztah added kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. impact/changelog process/cherry-picked and removed process/cherry-pick/27.x labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/rootless Rootless Mode impact/changelog kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. process/cherry-picked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rootlesskit check during install in rootless container fails build

3 participants