api/server/httputils: DecodePlatform: improve test-coverage#48680
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 17, 2024
Merged
api/server/httputils: DecodePlatform: improve test-coverage#48680thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Member
thaJeztah
commented
Oct 17, 2024
thaJeztah
commented
- Use fixtures for the JSON strings
- Add test-cases for invalid / malformed JSON
- Check error-message produced
- Add test for "happy path"
- Use fixtures for the JSON strings - Add test-cases for invalid / malformed JSON - Check error-message produced - Add test for "happy path" Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Oct 17, 2024
Comment on lines
+121
to
+126
| expectedErr: `failed to parse platform: unexpected end of JSON input`, | ||
| }, | ||
| { | ||
| doc: "not JSON", | ||
| platformJSON: `linux/ams64`, | ||
| expectedErr: `failed to parse platform: invalid character 'l' looking for beginning of value`, |
Member
Author
There was a problem hiding this comment.
FWIW; planning to make some improvements here after this;
- Friendlier messages for invalid / non-JSON
- Considering
osto be required, but possibly (TBD)architectureto be optional, - ☝️ but: if a
variantis specified, then architecture is required - Considering
os.featuresto be rejected; we currently don't use it for platform-matching, so it may be better to reject it until we do
Basically make the (from a CLI perspective) accepted format to be;
<os>[(os.version)][/architecture[/variant]]
vvoland
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.