container/integration: TestResize: add more test-cases, and add TestExecResize#48665
Merged
thaJeztah merged 2 commits intomoby:masterfrom Oct 16, 2024
Merged
container/integration: TestResize: add more test-cases, and add TestExecResize#48665thaJeztah merged 2 commits intomoby:masterfrom
thaJeztah merged 2 commits intomoby:masterfrom
Conversation
thaJeztah
force-pushed
the
integration_resize
branch
from
37f829a to
21b85cc
Compare
Member
Author
|
One failure on Windows; I saw other exec-tests were skipped on Windows, so maybe it's the same issue; |
thaJeztah
force-pushed
the
integration_resize
branch
from
21b85cc to
544e820
Compare
Member
Author
|
One more difference on Windows; stopping the container results in the Exec to be "not found" on the builtin driver; I can adjust the test; will have to wait for CI to complete to verify if it does the same with containerd as runtime. |
Add tests for various (invalid) sizes for resizing. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
integration_resize
branch
from
544e820 to
37ab5c3
Compare
Add integration tests for resizing exec's. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
integration_resize
branch
from
37ab5c3 to
44010e7
Compare
vvoland
approved these changes
Oct 16, 2024
| containertypes "github.com/docker/docker/api/types/container" | ||
| "github.com/docker/docker/errdefs" | ||
| "github.com/docker/docker/integration/internal/container" | ||
| req "github.com/docker/docker/testutil/request" |
Member
Author
There was a problem hiding this comment.
Oh, we don't; looks like this was because I copy/pasted bits in this file from the other one.
I'm working on a follow-up; I'll fix it up for both files there
| doc: "unset height", | ||
| height: valueNotSet, | ||
| width: "100", | ||
| expErr: `strconv.Atoi: parsing "": invalid syntax`, |
Contributor
There was a problem hiding this comment.
out of scope of this PR, but would be nice to have a better message here 😅
Member
Author
There was a problem hiding this comment.
Working on that exactly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- How to verify it
make TEST_FILTER='Test(ExecResize|Resize)' TEST_SKIP_INTEGRATION_CLI=1 DOCKER_GRAPHDRIVER=vfs test-integration- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)