gha: more limits, update alpine version, and some minor improvements#48654
Merged
neersighted merged 6 commits intomoby:masterfrom Oct 14, 2024
Merged
gha: more limits, update alpine version, and some minor improvements#48654neersighted merged 6 commits intomoby:masterfrom
neersighted merged 6 commits intomoby:masterfrom
Conversation
Regular runs are under a minute. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Regular runs are under 5 minutes. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Oct 12, 2024
|
|
||
| env: | ||
| ALPINE_VERSION: 3.16 | ||
| ALPINE_VERSION: 3.20 |
Member
Author
There was a problem hiding this comment.
Thank you YAML for being amazing! I really meant 3.20, not 3.2 😂
docker run --rm \
--quiet \
-v ./:/workspace \
-w /workspace \
-e VALIDATE_REPO \
-e VALIDATE_BRANCH \
alpine:3.2 sh -c 'apk add --no-cache -q bash git openssh-client && git config --system --add safe.directory /workspace && hack/validate/dco'
shell: /usr/bin/bash -e {0}
env:
ALPINE_VERSION: 3.2
VALIDATE_REPO: https://github.com/moby/moby.git
VALIDATE_BRANCH: masterAlpine 3.16 has been EOL for some time. Update to the latest version. Signed-off-by: Sebastiaan van Stijn <[email protected]>
- add `--quiet` to suppress pull progress output - use `./` instead of `$(pwd)` now that relative paths are supported - set the working directory on the container, so that we don't have to `cd` Signed-off-by: Sebastiaan van Stijn <[email protected]>
To be more explicit on what we're using. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
gha_more_limits_and_updates
branch
from
7171931 to
91c448b
Compare
- validate-prepare and smoke-prepare took 10 seconds; limiting to 10 minutes - smoke tests took less than 3 minutes; limiting to 10 minutes - validate: most took under a minute, but "deprecate-integration-cli" took 14 minutes; limiting to 30 minutes Signed-off-by: Sebastiaan van Stijn <[email protected]>
neersighted
approved these changes
Oct 14, 2024
This was referenced Nov 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gha: dco: limit to 10 minutes
Regular runs are under a minute.
gha: build (binary), build (dynbinary): limit to 20 minutes
Regular runs are under 5 minutes.
gha: dco: update ALPINE_VERSION to 3.20
Alpine 3.16 has been EOL for some time. Update to the latest version.
gha: dco: small tweaks to running the container
--quietto suppress pull progress output./instead of$(pwd)now that relative paths are supportedcdgha: use "ubuntu-24.04" instead of "ubuntu-latest"
To be more explicit on what we're using.
gha: shorter time limits for smoke, validate
14 minutes; limiting to 30 minutes