Skip to content

vendor: update minimum go version to 1.22#48614

Closed
thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah:test_pr
Closed

vendor: update minimum go version to 1.22#48614
thaJeztah wants to merge 2 commits intomoby:masterfrom
thaJeztah:test_pr

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

mostly testing CI for odd failures in #48613

Parsing raw definition
  /usr/bin/docker buildx bake --set *.output=type=docker,name=buildkit-tests --print integration-tests
  #1 [internal] load local bake definitions
  #1 reading docker-bake.hcl 3.83kB / 3.83kB done
  #1 DONE 0.0s
  ERROR: failed to find target integration-tests
Error: cannot parse bake definitions: ERROR: failed to find target integration-tests

The buildkit workflow uses Go to determine the version of Buildkit to run
integration-tests for. It currently uses on the default version that's
installed on the GitHub actions runners (1.21.13 currently), but this fails
if the go.mod/vendor.mod specify a higher version of Go as required version.

If this fails, the BUILDKIT_REF and REPO env-vars are not set / empty,
resulting in the workflow checking out the current (moby) repository instead
of buildkit, which fails.

This patch adds a step to explicitly install the expected version of Go.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member Author

This was done in #48613

@thaJeztah thaJeztah closed this Oct 10, 2024
@thaJeztah thaJeztah deleted the test_pr branch October 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant