Skip to content

Set NODAD on bridge IPv6 addresses#48609

Merged
thaJeztah merged 1 commit intomoby:masterfrom
robmry:nodad_bridge_address
Oct 8, 2024
Merged

Set NODAD on bridge IPv6 addresses#48609
thaJeztah merged 1 commit intomoby:masterfrom
robmry:nodad_bridge_address

Conversation

@robmry
Copy link
Copy Markdown
Contributor

@robmry robmry commented Oct 8, 2024

- What I did

New test TestAccessPublishedPortFromHost/userland-proxy=true/IPv6=true has been flaky.

It seems docker-proxy tends to bind to a link-local bridge address for its container-side connection when the bridge's unique-local address is (also) marked as tentative ... that means http requests from the host's netns fail. When the bridge addresses are no longer tentative, it works as expected.

- How I did it

Add bridge addresses with IFA_F_NODAD.

- How to verify it

TestAccessPublishedPortFromHost/userland-proxy=true/IPv6=true passes reliably.

- Description for the changelog

- disable IPv6 duplicate address detection (DAD) for addresses assigned to the bridges belonging to bridge networks

@robmry robmry added this to the 28.0.0 milestone Oct 8, 2024
@robmry robmry self-assigned this Oct 8, 2024
@robmry robmry marked this pull request as ready for review October 8, 2024 16:17
@robmry robmry requested a review from akerouanton October 8, 2024 16:17
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants