ci: run integration tests with firewalld enabled#48603
Merged
akerouanton merged 2 commits intomoby:masterfrom Oct 18, 2024
Merged
ci: run integration tests with firewalld enabled#48603akerouanton merged 2 commits intomoby:masterfrom
akerouanton merged 2 commits intomoby:masterfrom
Conversation
akerouanton
force-pushed
the
firewalld-ci-jobs
branch
from
e6e7012 to
ab594f4
Compare
akerouanton
changed the title
akerouanton
force-pushed
the
firewalld-ci-jobs
branch
3 times, most recently
from
963e313 to
e39b77a
Compare
vvoland
reviewed
Oct 15, 2024
akerouanton
force-pushed
the
firewalld-ci-jobs
branch
from
e39b77a to
124caf9
Compare
Signed-off-by: Albin Kerouanton <[email protected]>
Signed-off-by: Albin Kerouanton <[email protected]>
akerouanton
force-pushed
the
firewalld-ci-jobs
branch
from
124caf9 to
4e567e1
Compare
vvoland
approved these changes
Oct 17, 2024
robmry
approved these changes
Oct 18, 2024
This was referenced Oct 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Add firewalld support to our Makefile and Dockerfile. When
DOCKER_FIREWALLD=trueis set,make buildwill build an image with systemd and firewalld enabled. Container'seth0interface is put in firewalld'strustedzone to allow any connections coming from the host.A new firewalld 'mode' is added to the test matrix for
unit,integrationandintegration-clijobs. As we'll need to add yet another mode when we'll start working on nftables support, we should probably improve the test matrix in a follow-up to run less jobs (eg. there's no need to run networking tests with both the old graphdriver and c8d snapshotter).- How I did it
- How to verify it