Skip to content

Fix vendoring for moby/docker-image-spec#48592

Merged
thaJeztah merged 1 commit intomoby:masterfrom
robmry:fix_docker_image_spec_vendoring
Oct 7, 2024
Merged

Fix vendoring for moby/docker-image-spec#48592
thaJeztah merged 1 commit intomoby:masterfrom
robmry:fix_docker_image_spec_vendoring

Conversation

@robmry
Copy link
Copy Markdown
Contributor

@robmry robmry commented Oct 7, 2024

- What I did

Let hack/vendor.sh make changes related to:

- How I did it

Ran hack/vendor.sh.

- How to verify it

hack/validate/all.

- Description for the changelog

n/a

hack/vendor.sh has wanted to make these changes since
commit f5cc042.

Signed-off-by: Rob Murray <[email protected]>
@robmry robmry added kind/bugfix PR's that fix bugs area/go-sdk labels Oct 7, 2024
@robmry robmry added this to the 28.0.0 milestone Oct 7, 2024
@robmry robmry self-assigned this Oct 7, 2024
@robmry robmry requested a review from thaJeztah October 7, 2024 13:53
@thaJeztah
Copy link
Copy Markdown
Member

Interesting; wondering now why that other PR didn't complain, or was it still referenced somewhere? 🤔

@robmry
Copy link
Copy Markdown
Contributor Author

robmry commented Oct 7, 2024

Interesting; wondering now why that other PR didn't complain, or was it still referenced somewhere? 🤔

I think it's because the hack/validate/vendor script only does its thing if something changed in vendor/ ... so it just didn't notice the change.

@robmry robmry marked this pull request as ready for review October 7, 2024 15:01
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 352395c into moby:master Oct 7, 2024
@robmry robmry deleted the fix_docker_image_spec_vendoring branch October 8, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants