Log rather than error if port mapping is overspecified#48575
Merged
robmry merged 2 commits intomoby:masterfrom Oct 17, 2024
Merged
Log rather than error if port mapping is overspecified#48575robmry merged 2 commits intomoby:masterfrom
robmry merged 2 commits intomoby:masterfrom
Conversation
6de9036 to
a4c9c61
Compare
Signed-off-by: Rob Murray <[email protected]>
429fa1c to
c4a4659
Compare
Previously, if a port mapping specified a host IP or port that could not be used because the endpoint's network was in routed mode (so, there's no host binding), it'd be treated as an error. However: - the selected gateway endpoint may change over time, as networks are connected and disconnected - so the binding may make sense for some other endpoint. - the validation was complicated, duplicated logic in order to fail early, and wasn't complete. So, just log when fields are ignored, at the point where they're ignored. Signed-off-by: Rob Murray <[email protected]>
c4a4659 to
98efe66
Compare
akerouanton
approved these changes
Oct 7, 2024
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Previously, if a port mapping specified a host IP or port that could not be used because the endpoint's network was in routed mode (so, there's no host binding), it'd be treated as an error.
However:
- How I did it
So, just log when fields are ignored, at the point where they're ignored.
Removed the old validation function and its test.
Give the port mapping code a
contextcontaining a logger that adds network and endpoint ids.- How to verify it
Added unit tests for cases that were previously errors, checking the log output.
Example of the log message with extra context:
- Description for the changelog