client.ContainerCreate: use container.CreateRequest instead of local type#48553
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 26, 2024
Merged
Conversation
…type This function used a locally defined `configWrapper`, which was identical to the `container.CreateRequest`, with the exception of `CreateRequest` defining `omitempty` for HostConfig and NetworkingConfig, but this should not impact our use as the same type is used to handle the request on the daemon side. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/api
rumpl
approved these changes
Sep 26, 2024
krissetto
approved these changes
Sep 26, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function used a locally defined
configWrapper, which was identical to thecontainer.CreateRequest, with the exception ofCreateRequestdefiningomitemptyfor HostConfig and NetworkingConfig, but this should not impact our use as the same type is used to handle the request on the daemon side.