cmd/dockerd: use golang.org/x/sys/windows/service param-change consts#48513
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 17, 2024
Merged
cmd/dockerd: use golang.org/x/sys/windows/service param-change consts#48513thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
platform/windows
status/2-code-review
kind/refactor
thaJeztah
force-pushed
the
windows_svc_consts
branch
from
3bdc8c9 to
a2b99e9
Compare
Member
Author
|
This will conflict with #47412, so will need a rebase if that one gets merged first. |
- The `ParamChange` const was introduced in [golang/sys@e62c3de][1] - The `AcceptParamChange` const was introduced in [golang/sys@f7928cf][2] Both are part of golang.org/x/sys v0.1.0 and higher. [1]: golang/sys@e62c3de [2]: golang/sys@f7928cf Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
windows_svc_consts
branch
from
a2b99e9 to
0aebbd0
Compare
robmry
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParamChangeconst was introduced in golang/sys@e62c3deAcceptParamChangeconst was introduced in golang/sys@f7928cfBoth are part of golang.org/x/sys v0.1.0 and higher.