dockerd: fix docs, improve validation and improve coverage of "--feature" flag#48502
Merged
thaJeztah merged 5 commits intomoby:masterfrom Sep 16, 2024
Merged
dockerd: fix docs, improve validation and improve coverage of "--feature" flag#48502thaJeztah merged 5 commits intomoby:masterfrom
thaJeztah merged 5 commits intomoby:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/3-docs-review
area/docs
area/daemon
Member
Author
|
Some more things to address in this area; temporarily moving to draft |
The --feature flag allows the boolean value to be omitted. If only a name is provided, the default is "true". Signed-off-by: Sebastiaan van Stijn <[email protected]>
The value is optional for SetOpts (and NamedSetOpts), and implied "true" when omitted. This patch adds a test-case for this. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
thaJeztah
added
area/cli
This was referenced Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--featureto daemon flags #48167man: fix duplicate word in --feature flag description
man: dockerd: value is optional for --feature flag
The --feature flag allows the boolean value to be omitted. If only a name is provided, the default is "true".
internal/opts: SetOpts,NamedSetOpts: test for optional value
The value is optional for SetOpts (and NamedSetOpts), and implied "true" when omitted.
This patch adds a test-case for this.
internal/opts: SetOpts.Set: remove redundant var assignment
internal/opts: SetOpts: invalidate empty option-names