Skip to content

Update dlv in the dev-env#48497

Merged
thaJeztah merged 1 commit intomoby:masterfrom
robmry:update_dlv
Sep 14, 2024
Merged

Update dlv in the dev-env#48497
thaJeztah merged 1 commit intomoby:masterfrom
robmry:update_dlv

Conversation

@robmry
Copy link
Copy Markdown
Contributor

@robmry robmry commented Sep 13, 2024

- What I did

Got rid of WARNING: undefined behavior - version of Delve is too old for Go version go1.22.7 (maximum supported version 1.21).

- How I did it

Updated to https://github.com/go-delve/delve/releases/tag/v1.23.0

- How to verify it

Run dlv in the dev env.

- Description for the changelog

n/a

Signed-off-by: Rob Murray <[email protected]>
@robmry robmry requested a review from thaJeztah September 13, 2024 19:13
@thaJeztah
Copy link
Copy Markdown
Member

Oh! Would there be a way to validate this while building the image?

e.g., would running it with some option show that if needs an update? (trying to see if we can percent missing that it needs an update)

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants