Explicitly disable nvidia device injection for --gpus=0#48482
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 12, 2024
Merged
Explicitly disable nvidia device injection for --gpus=0#48482thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
This change ensures that when --gpus=0 is selected, the injection of NVIDIA device nodes and libraries is disabled by setting the NVIDIA_VISIBLE_DEVICES environment variable to void instead of leaving this unspecfied. Signed-off-by: Evan Lezar <[email protected]>
Contributor
Author
|
/cc @klueska @cdesiniotis |
laurazard
approved these changes
Sep 12, 2024
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that when --gpus=0 is selected, the injection of NVIDIA device nodes and libraries is disabled by setting the NVIDIA_VISIBLE_DEVICES environment variable to void instead of leaving this unspecfied.
- What I did
Updated the handling of the
--gpus=0flag to ensure that theNVIDIA_VISBLE_DEVICESenvvar in the container is set tovoidinstead of being left unspecified.- How I did it
Added a conditional check for
Count == 0when theNVIDIA_VISBLE_DEVICESenvvar is being constructed.- How to verify it
Running:
and
should show no devices or libraries on a system with NVIDIA GPUs.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)